Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming: Make all Palette properties virtual #6519

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

TDroogers
Copy link
Contributor

Description

Followup for #5676
Mark all Pelette variables virtual so you can inherent Palette in your own object like I did for PaletteDark.
Also marked Pelette Obsolete, mostly to inform people about the existence of PaletteDark

How Has This Been Tested?

Visual, don't know how this could be tested with unit tests.
Tested if Pelette can be marked abstract for the doc project and changed doc to make sure it works.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement New feature or request PR: needs review labels Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fe5273d) 91.17% compared to head (a0e94f0) 91.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6519   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files         392      392           
  Lines       14836    14836           
=======================================
  Hits        13527    13527           
  Misses       1309     1309           
Impacted Files Coverage Δ
src/MudBlazor/Themes/Models/Palette.cs 78.08% <100.00%> (ø)
src/MudBlazor/Themes/MudTheme.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TDroogers
Copy link
Contributor Author

@henon A small improvement on my old PR #5676, decided to LightPallete like it was discussed in that PR.

@henon henon changed the title Theming: Mark all Pelette variables virtual Theming: Make all Palette properties virtual Mar 24, 2023
@henon henon merged commit e221bfb into MudBlazor:dev Mar 24, 2023
@henon
Copy link
Collaborator

henon commented Mar 24, 2023

I totally agree. We'll make it abstract with v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants