Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes MudDataGrid NullReferenceExeption #6541

Merged
merged 4 commits into from Mar 28, 2023
Merged

Fixes MudDataGrid NullReferenceExeption #6541

merged 4 commits into from Mar 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 27, 2023 •
edited by henon

Description

Fixes MudDataGrid NullReferenceExeption when rendering a null if the PropertyColumn has formatting
Fixes #6529

How Has This Been Tested?

Unit tests and visually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

alfadelta88 added 4 commits March 26, 2023 14:08
@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Mar 27, 2023
@ghost ghost mentioned this pull request Mar 27, 2023
Merged
6 tasks
@ScarletKuro
Copy link
Member

@henon @tjscience would be nice to merge this asap.

henon
henon approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect PR, Thanks!

@henon henon merged commit cf130f1 into MudBlazor:dev Mar 28, 2023
@henon
Copy link
Collaborator

henon commented Mar 28, 2023

@HClausing is the issue you reported fixed by this too?

@ghost ghost deleted the fixes-6529 branch March 28, 2023 08:54
@HClausing
Copy link
Member

@HClausing is the issue you reported fixed by this too?

I didn't test this branch directly but looking at the code I'm sure it will work as expected.

Is there a dev release for testing?

@henon
Copy link
Collaborator

henon commented Mar 28, 2023

Here you go: https://www.nuget.org/packages/MudBlazor/6.2.1-dev1

@Yomodo
Copy link
Contributor

Yomodo commented Mar 28, 2023 •
edited

@henon v6.2.1-dev1 nuget shows "False" on all my mudtables.

image

@henon
Copy link
Collaborator

henon commented Mar 28, 2023 •
edited

hmm, did I do something wrong in the build process? I'll clean and try again. Don't see any of those on https://dev.mudblazor.com/components/table

Edit: I spoke too soon. This is a regression
image

@henon
Copy link
Collaborator

henon commented Mar 28, 2023

I suspect this: bace647#r106458878

@henon
Copy link
Collaborator

henon commented Mar 29, 2023

Fixed.

@henon
Copy link
Collaborator

henon commented Mar 30, 2023

Made a new pre-release covering recently fixed DataGrid regressions: https://www.nuget.org/packages/MudBlazor/6.2.1-dev2

ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@ilovepilav
Fixes MudDataGrid NullReferenceExeption (MudBlazor#6541)
ef2beda 
* Update MudDataGrid.razor

Fixes MudBlazor#6529 (MudDataGrid NullReferenceException when using PropertyColumn with formatting)

* Tests added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MudDataGrid NullReferenceException when using PropertyColumn with formatting
4 participants
@ScarletKuro @henon @HClausing @Yomodo