Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IconsPage: remove fixed height to fix footer position (#6532) #6542

Merged
merged 1 commit into from
Apr 1, 2023
Merged

IconsPage: remove fixed height to fix footer position (#6532) #6542

merged 1 commit into from
Apr 1, 2023

Conversation

KBM-Kevin-Kessler
Copy link
Contributor

@KBM-Kevin-Kessler KBM-Kevin-Kessler commented Mar 27, 2023 •
edited by henon

Description

Hello this is my first contribution to this project. I hope i made everything correct. Otherwise let me know.

This Pull Request Closes #6532 and closes #5493

The container had a fixed height of 34000px, which moved the footer to that position. Depending on the number of icons, the footer covered the icons or for the custom icons (less icons) the page was unnecessary large.

How Has This Been Tested?

Visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Before:
Material Icons:
image

Custom Icons:
image

After:
Material Icons:
image
Custom Icons:
image

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@KBM-Kevin-Kessler
IconsPage: remove fixed height to fix footer position
24f7dbd 
The container had a fixed height of 34000px, which moved the footer to that position. Depending on the number of icons, the footer covered the icons or for the custom icons (less icons) the page was unnecessary large.
@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Mar 27, 2023
@KBM-Kevin-Kessler KBM-Kevin-Kessler mentioned this pull request Mar 27, 2023
Closed
2 tasks
@ScarletKuro
Copy link
Member

@henon what do you think, is this acceptable fix? Since #6532 is indeed annoying, would be nice to get rid of this.

@henon henon added docs Related to docs and removed bug Something does not work as intended/expected PR: needs review labels Apr 1, 2023
@henon henon merged commit edb41e3 into MudBlazor:dev Apr 1, 2023
@henon
Copy link
Collaborator

henon commented Apr 1, 2023

Thanks Kevin!

ScarletKuro pushed a commit to ScarletKuro/MudBlazor that referenced this pull request Apr 4, 2023
@KBM-Kevin-Kessler @ScarletKuro
IconsPage: remove fixed height to fix footer position (MudBlazor#6542)
e1865ac 
The container had a fixed height of 34000px, which moved the footer to that position. Depending on the number of icons, the footer covered the icons or for the custom icons (less icons) the page was unnecessary large.
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@KBM-Kevin-Kessler @ilovepilav
IconsPage: remove fixed height to fix footer position (MudBlazor#6542)
9afb5c8 
The container had a fixed height of 34000px, which moved the footer to that position. Depending on the number of icons, the footer covered the icons or for the custom icons (less icons) the page was unnecessary large.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Related to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong Links on Mudblazor Icons Web-Page Docs : Button in middle of icons.
3 participants
@KBM-Kevin-Kessler @ScarletKuro @henon