Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudAvatar: Add nullable annotation #6543

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

ScarletKuro
Copy link
Member

Description

Part of this issue #6535

No open pull requests for MudAvatar.

How Has This Been Tested?

No tests required in case of MudAvatar

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change, improve null diagnostic warnings)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@ScarletKuro
Copy link
Member Author

ScarletKuro commented Mar 27, 2023

Included MudComponentBase annotation as well, should have done it earlier since all components inherit from it.

few nits (future?) for MudComponentBase: UserAttributes should be IReadOnlyDictionary since it should be immutable.
Instead of UserAttributes.Contains("XYZ") -> UserAttributes["XYZ"] it would b nice to use TryGetValue(key, ref) since it's more optimized. ContainsKey + Item is about 40% slower.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (eaf5d78) 91.37% compared to head (7b794f2) 91.47%.

❗ Current head 7b794f2 differs from pull request most recent head faba67a. Consider uploading reports for the commit faba67a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6543      +/-   ##
==========================================
+ Coverage   91.37%   91.47%   +0.10%     
==========================================
  Files         397      393       -4     
  Lines       14909    14875      -34     
==========================================
- Hits        13623    13607      -16     
+ Misses       1286     1268      -18     
Impacted Files Coverage Δ
src/MudBlazor/Components/Avatar/MudAvatar.razor.cs 100.00% <ø> (ø)
src/MudBlazor/Base/MudComponentBase.cs 100.00% <100.00%> (ø)
...udBlazor/Components/Avatar/MudAvatarGroup.razor.cs 100.00% <100.00%> (ø)

... and 19 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ScarletKuro
Copy link
Member Author

If no objections, then good to merge.

@ScarletKuro
Copy link
Member Author

Rebased and fixed the conflicts.

@henon henon merged commit 21ae6d1 into MudBlazor:dev Mar 31, 2023
@ScarletKuro ScarletKuro deleted the avatar_nullable branch April 1, 2023 20:00
ScarletKuro added a commit to ScarletKuro/MudBlazor that referenced this pull request Apr 4, 2023
@ScarletKuro ScarletKuro added enhancement New feature or request and removed PR: needs review labels Jun 29, 2023
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants