Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudBadge: Add nullable annotation. #6554

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

ScarletKuro
Copy link
Member

Description

Part of this issue #6535

How Has This Been Tested?

No tests required in case of MudBadge

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change, improve null diagnostic warnings)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.29 🎉

Comparison is base (e23518e) 91.17% compared to head (89902e4) 91.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6554      +/-   ##
==========================================
+ Coverage   91.17%   91.46%   +0.29%     
==========================================
  Files         392      393       +1     
  Lines       14836    14874      +38     
==========================================
+ Hits        13527    13605      +78     
+ Misses       1309     1269      -40     
Impacted Files Coverage Δ
src/MudBlazor/Components/Badge/MudBadge.razor.cs 100.00% <ø> (ø)
src/MudBlazor/Components/Badge/MudBadge.razor 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ScarletKuro
Copy link
Member Author

@henon

@henon henon added enhancement New feature or request and removed PR: needs review labels Mar 29, 2023
@henon henon merged commit 465f37b into MudBlazor:dev Mar 29, 2023
@ScarletKuro ScarletKuro deleted the badge_nullable branch March 29, 2023 18:48
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants