-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileUpload: Add Disabled property #6572
FileUpload: Add Disabled property #6572
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #6572 +/- ##
==========================================
- Coverage 91.47% 91.37% -0.10%
==========================================
Files 393 397 +4
Lines 14877 14919 +42
==========================================
+ Hits 13608 13632 +24
- Misses 1269 1287 +18
... and 23 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
[Parameter] | ||
[Category(CategoryTypes.FileUpload.Behavior)] | ||
public bool Disabled { get; set; } | ||
[CascadingParameter(Name = "ParentDisabled")] private bool ParentDisabled { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a new line between the attribute and property, because it would align with the rest of the file style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This style (no newline following attribute) is consistent with the usage of CascadingParameter elsewhere.
* Add Disabled property to FileUpload and cascade BaseButton disabled state. * Style changes. * Refactor CascadingValue.
* Add Disabled property to FileUpload and cascade BaseButton disabled state. * Style changes. * Refactor CascadingValue.
Description
This is the sister PR to #6511 and adds a
Disabled
property to theMudFileUpload
.This PR also adds a
ParentDisabled
cascading value to theMudBaseButton
, allowing it to inherit itsDisabled
state from theMudFileUpload
as well as theMudForm
once #6511 is merged.How Has This Been Tested?
I have added two unit tests.
Types of changes
Checklist:
dev
).