Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MudDrawer: Fix #6154 by not re-rendering on mouse events #6575

Merged
merged 1 commit into from
Apr 1, 2023
Merged

MudDrawer: Fix #6154 by not re-rendering on mouse events #6575

merged 1 commit into from
Apr 1, 2023

Conversation

ScarletKuro
Copy link
Member

Description

Fixes #6154

How Has This Been Tested?

Manual testing on the https://try.mudblazor.com/snippet/QkwROPvgFalrIyof
Made sure the events still are being called and the rerender is not happening

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 1, 2023
@ScarletKuro
Copy link
Member Author

ScarletKuro commented Apr 1, 2023 •
edited

Tried to write a unit test, but seems like bUnit is not able to fully reproduce the behavior.
OnParametersSet is not being triggered when you trigger the onmouseenter, onmouseleave from the unit test, which mean unit testing this case is useless.
However manual testing does show a difference.

@ScarletKuro ScarletKuro requested a review from henon April 1, 2023 02:40
@henon henon changed the title MudDrawer: Fix #6154 to not re-render on OnMouseEnter / OnMouseLeave MudDrawer: Fix #6154 by not re-rendering on mouse events Apr 1, 2023
@henon henon merged commit 295d231 into MudBlazor:dev Apr 1, 2023
@henon
Copy link
Collaborator

henon commented Apr 1, 2023

Thanks a lot!

@ScarletKuro ScarletKuro deleted the fix_6154 branch April 1, 2023 10:45
ScarletKuro added a commit to ScarletKuro/MudBlazor that referenced this pull request Apr 4, 2023
@ScarletKuro
MudDrawer: Fix MudBlazor#6154 by not re-rendering on mouse events (Mu…
8567c07 
…dBlazor#6575)
@ScarletKuro ScarletKuro mentioned this pull request Apr 10, 2023
Closed
2 tasks
@ScarletKuro ScarletKuro mentioned this pull request Apr 18, 2023
Open
2 tasks
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@ScarletKuro @ilovepilav
MudDrawer: Fix MudBlazor#6154 by not re-rendering on mouse events (Mu…
55a6c21 
…dBlazor#6575)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henon henon Awaiting requested review from henon

Assignees
No one assigned
Labels
bug Something does not work as intended/expected PR: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MudDrawer child component OnParametersSet() getting called on mouse hover
2 participants
@ScarletKuro @henon