Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudIcon: Add nullable annotation. #6578

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Conversation

ScarletKuro
Copy link
Member

Description

Part of this issue #6535

How Has This Been Tested?

No tests required in case of MudIcon

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change, improve null diagnostic warnings)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f228506) 91.38% compared to head (b1d703a) 91.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6578   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         397      397           
  Lines       14940    14940           
=======================================
  Hits        13653    13653           
  Misses       1287     1287           
Impacted Files Coverage Δ
src/MudBlazor/Components/Icon/MudIcon.razor 100.00% <100.00%> (ø)
src/MudBlazor/Components/Icon/MudIcon.razor.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ScarletKuro ScarletKuro requested a review from henon April 1, 2023 16:14
@henon henon merged commit 331469f into MudBlazor:dev Apr 1, 2023
ScarletKuro added a commit to ScarletKuro/MudBlazor that referenced this pull request Apr 4, 2023
@ScarletKuro ScarletKuro deleted the icon_nullable branch April 8, 2023 23:40
@ScarletKuro ScarletKuro added enhancement New feature or request and removed PR: needs review labels Jun 29, 2023
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants