MudPopover: Fix flickering in delayed bss (#6345) #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #6579 +/- ##
=======================================
Coverage 91.38% 91.39%
=======================================
Files 397 397
Lines 14940 14953 +13
=======================================
+ Hits 13653 13666 +13
Misses 1287 1287
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Maybe, I should have asked the original author to update his PR, but kinda didn't look that it's ~1month old |
|
Kudos. |
ScarletKuro
added a commit
to ScarletKuro/MudBlazor
that referenced
this pull request
Apr 4, 2023
…#6579) Co-authored-by: gaplin <50521366+gaplin@users.noreply.github.com>
ilovepilav
pushed a commit
to ilovepilav/MudBlazor
that referenced
this pull request
Nov 25, 2023
…#6579) Co-authored-by: gaplin <50521366+gaplin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revives this PR #6389 (conflicts + breaking change)
Fixes #6345
Compared to original PR this is not breaking one.
The original PR changed public API
old PR:
void UpdateFragment->Task UpdateFragmentthis PR: introduce new method
Task UpdateFragmentAsyncThe
UpdateFragmentis marked as Obsolete now.I had to copy-paste some tests that using the old method, but I think it's better to keep the unit tests for old method for now to make sure everything is backward compatible and working. There are some new tests as well (from original PR).
How Has This Been Tested?
Unit tests, mud docs.
Types of changes
Checklist:
dev).