Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudDialogInstance: return back public API ForceRender #6588

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

ScarletKuro
Copy link
Member

Description

As @mckaragoz noticed, the ForceRender was removed because of this #6563 PR
This was unintentional, as it's public API.
The StateHasChanged is made visible compared to the explicit implementation in the MudComponentBase.
This is due to the special need of such method for the DialogInstance.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

@ScarletKuro ScarletKuro requested a review from henon April 4, 2023 18:32
@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (2df95f8) 91.39% compared to head (7711282) 91.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6588      +/-   ##
==========================================
- Coverage   91.39%   91.38%   -0.01%     
==========================================
  Files         397      397              
  Lines       14953    14955       +2     
==========================================
+ Hits        13666    13667       +1     
- Misses       1287     1288       +1     
Impacted Files Coverage Δ
...lazor/Components/Dialog/MudDialogInstance.razor.cs 82.17% <50.00%> (-0.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henon henon removed PR: needs review bug Something does not work as intended/expected labels Apr 4, 2023
@henon henon merged commit 8b4454d into MudBlazor:dev Apr 4, 2023
3 of 4 checks passed
@henon
Copy link
Collaborator

henon commented Apr 4, 2023

Thanks. Removed the bug tag since this fixes a regression that was never released, so it doesn't need to be in the change log

@ScarletKuro ScarletKuro deleted the forcerender branch April 8, 2023 17:30
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants