Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudDataGrid: Fix ExpandAllGroups/CollapseAllGroups skipping some groups (#6591) #6592

Merged
merged 3 commits into from Apr 7, 2023
Merged

MudDataGrid: Fix ExpandAllGroups/CollapseAllGroups skipping some groups (#6591) #6592

merged 3 commits into from Apr 7, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2023

Description

fixes #6591

How Has This Been Tested?

visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 88.23% and project coverage change: -0.01 ⚠️

Comparison is base (07a63a7) 91.42% compared to head (e471d4b) 91.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6592      +/-   ##
==========================================
- Coverage   91.42%   91.42%   -0.01%     
==========================================
  Files         398      398              
  Lines       14959    14954       -5     
==========================================
- Hits        13677    13671       -6     
- Misses       1282     1283       +1     
Impacted Files Coverage Δ
...azor/Components/Autocomplete/MudAutocomplete.razor 96.00% <ø> (ø)
...MudBlazor/Components/DataGrid/MudDataGrid.razor.cs 88.23% <85.71%> (-0.08%) ⬇️
...rc/MudBlazor/Components/DataGrid/MudDataGrid.razor 99.11% <100.00%> (ø)
src/MudBlazor/Components/Input/MudInput.razor 100.00% <100.00%> (ø)
src/MudBlazor/Components/Input/MudInput.razor.cs 85.18% <100.00%> (-2.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost ghost mentioned this pull request Apr 6, 2023
8 tasks
@henon
Copy link
Collaborator

henon commented Apr 6, 2023

Ideally the fix is covered by a test that fails without it and stops failing with the fix.

@ghost
Copy link
Author

ghost commented Apr 6, 2023

Alright, I'll see what I can do when I get my hands on my computer this evening.

@henon henon changed the title MudDataGrid: Fixes ExpandAllGroups/CollapseAllGroups skipping some groups (#6591) MudDataGrid: Fix ExpandAllGroups/CollapseAllGroups skipping some groups (#6591) Apr 7, 2023
@henon henon merged commit cdbeeed into MudBlazor:dev Apr 7, 2023
2 of 3 checks passed
@henon
Copy link
Collaborator

henon commented Apr 7, 2023

Thanks a lot!

@ghost ghost deleted the fix/6591 branch April 7, 2023 20:15
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
…ps (MudBlazor#6591) (MudBlazor#6592)

* MudDataGrid: Fixes ExpandAllGroups/CollapseAllGroups skipping some groups (MudBlazor#6591)

* Add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudDataGrid ExpandAllGroups/CollapseAllGroups skips some groups
2 participants