Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete: Should not have a Clear button when ReadOnly #6596

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Autocomplete: Should not have a Clear button when ReadOnly #6596

merged 3 commits into from
Apr 6, 2023

Conversation

Mr-Technician
Copy link
Member

Description

The Autocomplete should not have a Clear button when ReadOnly.

How Has This Been Tested?

Unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 6, 2023
@Mr-Technician Mr-Technician requested a review from henon April 6, 2023 16:28
henon
henon approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@henon henon merged commit 32eb277 into MudBlazor:dev Apr 6, 2023
1 check passed
@neozhu
Copy link
Contributor

neozhu commented Apr 6, 2023

image

Can you refer to the form style of Salesforce? When the field property is set to "read-only", a small pen icon will appear on the right side. Users can click the icon to switch to edit mode. Do you think this is feasible?

@henon
Copy link
Collaborator

henon commented Apr 7, 2023

@neozhu can't you do that yourself by binding an icon button against the disabled property of a form component?

ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@Mr-Technician @ilovepilav
Autocomplete: Should not have a Clear button when ReadOnly (MudBlazor…
2ee7f01 
…#6596)

* Readonly autocomplete should not have a clearable button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henon henon henon approved these changes

Assignees
No one assigned
Labels
bug Something does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mr-Technician @neozhu @henon