Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudDataGrid: Fix GroupExpanded not working #6604

Merged
merged 1 commit into from Apr 8, 2023
Merged

MudDataGrid: Fix GroupExpanded not working #6604

merged 1 commit into from Apr 8, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2023

Description

Fixes GroupExpanded not working regression in #6555

How Has This Been Tested?

unit | visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.01 ⚠️

Comparison is base (cdbeeed) 91.42% compared to head (cb0d6bb) 91.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6604      +/-   ##
==========================================
- Coverage   91.42%   91.41%   -0.01%     
==========================================
  Files         398      398              
  Lines       14954    14955       +1     
==========================================
  Hits        13671    13671              
- Misses       1283     1284       +1     
Impacted Files Coverage Δ
...MudBlazor/Components/DataGrid/MudDataGrid.razor.cs 88.02% <83.33%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost ghost mentioned this pull request Apr 7, 2023
8 tasks
@henon henon merged commit cbb61dc into MudBlazor:dev Apr 8, 2023
3 of 4 checks passed
@henon
Copy link
Collaborator

henon commented Apr 8, 2023

Awesome, thanks @alfadelta88

FYI @HClausing, @tjscience

@ghost ghost deleted the fix/muddatagrid-groupexpanded branch April 8, 2023 13:05
@PaulTodd
Copy link

PaulTodd commented May 3, 2023

@henon @alfadelta88 GroupExpanded still doesn't seem to be working in the latest version: https://try.mudblazor.com/snippet/wOmxkzaxzeKJAHca

@HClausing
Copy link
Member

@henon @alfadelta88 GroupExpanded still doesn't seem to be working in the latest version: https://try.mudblazor.com/snippet/wOmxkzaxzeKJAHca

I'm not sure about it, but it can be present only in preview release.

@henon
Copy link
Collaborator

henon commented May 3, 2023

I just released v6.2.3. If it is still not working let us know.

@PaulTodd
Copy link

PaulTodd commented May 3, 2023

That seems to have fixed it. Thank you.

ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants