Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudFormComponent: Add nullable annotation. #6608

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Apr 8, 2023

Description

Part of this issue #6535
To continue annotation need to annotate some main classes.
It also annotates the Converter which is important for the component.

There is one change additional change that it check that error is not null but also not empty (""), doesn't look like it would be desired to have empty lines in the error list.

How Has This Been Tested?

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change, improve null diagnostic warnings)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage: 94.33% and project coverage change: -0.01 ⚠️

Comparison is base (50da41d) 90.55% compared to head (b2c2f84) 90.54%.

❗ Current head b2c2f84 differs from pull request most recent head 35ef48a. Consider uploading reports for the commit 35ef48a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6608      +/-   ##
==========================================
- Coverage   90.55%   90.54%   -0.01%     
==========================================
  Files         399      399              
  Lines       13610    13615       +5     
==========================================
+ Hits        12324    12328       +4     
- Misses       1286     1287       +1     
Impacted Files Coverage Δ
src/MudBlazor/Extensions/ExpressionExtensions.cs 100.00% <ø> (ø)
...MudBlazor/Utilities/BindingConverters/Converter.cs 74.19% <ø> (ø)
src/MudBlazor/Base/MudFormComponent.cs 78.43% <94.33%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ScarletKuro
Copy link
Member Author

ScarletKuro commented Apr 9, 2023

Do not merge yet.
Ready now.

@ScarletKuro ScarletKuro requested a review from henon April 12, 2023 18:43
@henon henon merged commit 2ff129a into MudBlazor:dev Apr 14, 2023
3 checks passed
@ScarletKuro ScarletKuro deleted the MudFormComponent_nullable branch April 14, 2023 11:29
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants