Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudDataGrid: Rename AddFilterAsync and ClearFiltersAsync (Breaking Change) #6639

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Apr 12, 2023

Description

This PR #6627 introduced AndForget() calls in the public API, which we consider to be risky. As a result, we have decided to modify the public API and replace the AndForget() calls with async versions that will use await. Furthermore, since DataGrid generally has an async nature, this change makes sense.

How Has This Been Tested?

Unit test + docs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 53.65% and project coverage change: +0.15 🎉

Comparison is base (1a662ed) 90.48% compared to head (8377240) 90.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6639      +/-   ##
==========================================
+ Coverage   90.48%   90.64%   +0.15%     
==========================================
  Files         399      399              
  Lines       13617    13610       -7     
==========================================
+ Hits        12322    12337      +15     
+ Misses       1295     1273      -22     
Impacted Files Coverage Δ
src/MudBlazor/Components/DataGrid/Filter.cs 77.96% <0.00%> (ø)
...dBlazor/Components/DataGrid/FilterHeaderCell.razor 37.50% <0.00%> (ø)
src/MudBlazor/Components/DataGrid/HeaderCell.razor 89.65% <ø> (ø)
...rc/MudBlazor/Components/DataGrid/MudDataGrid.razor 88.33% <ø> (ø)
src/MudBlazor/Components/DataGrid/FilterContext.cs 54.54% <25.00%> (-16.89%) ⬇️
...azor/Components/DataGrid/FilterHeaderCell.razor.cs 42.85% <45.45%> (+13.94%) ⬆️
.../MudBlazor/Components/DataGrid/HeaderCell.razor.cs 71.92% <53.84%> (+3.44%) ⬆️
...MudBlazor/Components/DataGrid/MudDataGrid.razor.cs 91.14% <81.81%> (+1.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ScarletKuro ScarletKuro changed the title MudDataGrid: AddFilter -> AddFilterAsync, ClearFilters -> ClearFilter -> ClearFilterAsync MudDataGrid: AddFilter -> AddFilterAsync, ClearFilters -> ClearFilterAsync Apr 12, 2023
@henon henon changed the title MudDataGrid: AddFilter -> AddFilterAsync, ClearFilters -> ClearFilterAsync MudDataGrid: Rename AddFilterAsync and ClearFiltersAsync (Breaking Change) Apr 12, 2023
@henon henon merged commit 75a687c into MudBlazor:dev Apr 12, 2023
3 of 4 checks passed
@ScarletKuro ScarletKuro deleted the datagrid_async branch April 12, 2023 18:19
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants