Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudButtonGroup: Add nullable annotation. #6640

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Apr 12, 2023

Description

Part of this issue #6535

Used re-sharpers new analyze for reducing the number of lookups in collections
from

if(!UserAttributes.ContainsKey("role")) 
  UserAttributes.Add("role", "group");

to

UserAttributes.TryAdd("role", "group");

Furthermore, we agreed to apply a code style change when applicable: new line after attribute. Also, fix the indentation for CssBuilder.

How Has This Been Tested?

No tests required in case of MudButtonGroup

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change, improve null diagnostic warnings)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (50da41d) 90.55% compared to head (7e42fc9) 90.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6640      +/-   ##
==========================================
- Coverage   90.55%   90.55%   -0.01%     
==========================================
  Files         399      399              
  Lines       13610    13609       -1     
==========================================
- Hits        12324    12323       -1     
  Misses       1286     1286              
Impacted Files Coverage Δ
...Blazor/Components/ButtonGroup/MudButtonGroup.razor 100.00% <100.00%> (ø)
...zor/Components/ButtonGroup/MudButtonGroup.razor.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ScarletKuro ScarletKuro requested a review from henon April 12, 2023 19:16
@henon henon merged commit ffed90e into MudBlazor:dev Apr 14, 2023
4 checks passed
@henon
Copy link
Collaborator

henon commented Apr 14, 2023

Thanks Kuro

@ScarletKuro ScarletKuro deleted the buttongroup_nullable branch April 14, 2023 11:28
@ScarletKuro ScarletKuro added enhancement New feature or request and removed PR: needs review labels Jun 29, 2023
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants