Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudDataGrid: Fix GroupExpanded when using ServerData #6667

Merged
merged 2 commits into from Apr 16, 2023
Merged

MudDataGrid: Fix GroupExpanded when using ServerData #6667

merged 2 commits into from Apr 16, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2023

Description

Fixes GroupExpanded not working regression when using ServerData, caused by PR #6660.

How Has This Been Tested?

unit | visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 15, 2023
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (09e619a) 90.45% compared to head (388392b) 90.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6667   +/-   ##
=======================================
  Coverage   90.45%   90.45%           
=======================================
  Files         399      399           
  Lines       13632    13632           
=======================================
  Hits        12331    12331           
  Misses       1301     1301           
Impacted Files Coverage Δ
...MudBlazor/Components/DataGrid/MudDataGrid.razor.cs 90.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ScarletKuro ScarletKuro requested a review from henon April 16, 2023 10:43
@henon henon merged commit 4a24c1b into MudBlazor:dev Apr 16, 2023
4 checks passed
@henon
Copy link
Collaborator

henon commented Apr 16, 2023

Thanks @alfadelta88, you have been a great help! FYI @tjscience

@ghost ghost deleted the fix/muddatagrid-groupexpanded-serverdata branch April 16, 2023 13:41
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected PR: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants