Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudLineChart: remove Integrate() call because the return not used #7691

Merged

Conversation

GeeSuth
Copy link
Contributor

@GeeSuth GeeSuth commented Oct 25, 2023

Description

follow up #1139 (comment) this code obviously not used else where, even in UI

How Has This Been Tested?

I never noticed used the return value in same class in all return/set variable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@ScarletKuro
Copy link
Member

Yeah, I think it's not used. I remember contacting the original author about this #1139 (comment)

@ScarletKuro
Copy link
Member

ScarletKuro commented Oct 25, 2023

Can you make the PR tp follow the template with description, how it was tested, type of change and so on?

@ScarletKuro ScarletKuro added the enhancement New feature or request label Oct 25, 2023
@GeeSuth
Copy link
Contributor Author

GeeSuth commented Oct 25, 2023

Sure, sorry for that

@GeeSuth
Copy link
Contributor Author

GeeSuth commented Oct 25, 2023

Yeah, I think it's not used. I remember contacting the original author about this #1139 (comment)

Interesting, I don't notice this before.
but seems good we both notice that.

@henon henon changed the title remove Integrate() call because the return not used MudLineChart: remove Integrate() call because the return not used Oct 26, 2023
@henon henon merged commit b5045a2 into MudBlazor:dev Oct 26, 2023
3 of 4 checks passed
@henon
Copy link
Collaborator

henon commented Oct 26, 2023

Thanks @GeeSuth

ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants