DataGrid: Fix empty footer row when using SelectColumn with ShowInFooter=false
#7747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with the `SelectColumn` when setting `ShowInFooter` to `false`. Previously this would render a footer row (more specifically some `td`'s with the `footer-cell` CSS class) that would take up some height.
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7747 +/- ##
==========================================
- Coverage 89.78% 87.44% -2.34%
==========================================
Files 411 393 -18
Lines 11840 11641 -199
Branches 2363 2330 -33
==========================================
- Hits 10630 10179 -451
- Misses 682 950 +268
+ Partials 528 512 -16 ☔ View full report in Codecov by Sentry. |
mikes-gh
changed the title
SelectColumn with ShowInFooter=falseSelectColumn with ShowInFooter=false
tjscience
approved these changes
Mar 24, 2024
|
Ugh, I somehow missed this. I added tj to review, but didn't subscribe on updates... |
|
@ScarletKuro Been busy with work on my end too so thanks for the reminder! Fixing it up right now. |
|
@ScarletKuro Done, good to go! |
danielchalmers
pushed a commit
to danielchalmers/MudBlazor
that referenced
this pull request
Apr 7, 2024
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with the
SelectColumnwhen settingShowInFootertofalse.Previously this would render a footer row (more specifically some
td's with thefooter-cellCSS class) that would take up some height.Open to suggestions for a better solution if there is one for this case, I admit I didn't go deeper into the
FooterTemplaterendering on theMudDataGridside of things.Reproduction (docs example with
ShowInFooter = false): https://try.mudblazor.com/snippet/QOwHlvajhmmyCBhMHow Has This Been Tested?
bUnit tested
Types of changes
Previous behaviour:
firefox_FUNYj65Xl4.mp4
New behaviour:
firefox_DU3DTeB3yy.mp4
Checklist:
dev).