MudMenuItem: Don't "click" when scrolling menu on touch devices (#7262) #7809
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue which touchscreen users cannot scroll MudMenu without invoking OnTouchHandler
Resolves #7262
Added a private boolean "_isTouchMoved" to the MudMenuItem which only true when
ontouchmove
for stopping OnTouchHandler invoke.Touch events always start with
ontouchstart
so we're making "_isTouchMoved" false back whenontouchstart
.MudMenuItem's OnTouchHandler already binded to
ontouchend
event so it always works when the user just touches.ontouchstart
+ontouchmove
+ontouchend
(OnTouchHandler called) => ❌ontouchstart
+ontouchend
(OnTouchHandler called) => ✅How Has This Been Tested?
MenuItemActionTest
viewTypes of changes
Before.MP4
After_Fix.MP4
Menu_Scroll_Test_After_Fix.MP4
Checklist:
dev
).