Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGrid: Fix FilterDefinition.Title not updating when selected field is changed #7821

Merged

Conversation

Saman-00
Copy link
Contributor

Description

Title Property of FilterDefinition doesn't get updated when the user changes the filter field in DataGrid when FilterMode is DataGridFilterMode.Simple.

How Has This Been Tested?

Manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (df6d943) 87.19% compared to head (d1f7d0f) 87.18%.

Files Patch % Lines
src/MudBlazor/Components/DataGrid/Filter.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7821      +/-   ##
==========================================
- Coverage   87.19%   87.18%   -0.01%     
==========================================
  Files         389      389              
  Lines       11421    11422       +1     
  Branches     2299     2299              
==========================================
  Hits         9958     9958              
- Misses        966      967       +1     
  Partials      497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikes-gh mikes-gh changed the title MudDataGrid: Fix FilterDefinition.Title not updating when selected field is changed DataGrid: Fix FilterDefinition.Title not updating when selected field is changed Feb 1, 2024
Copy link
Contributor

@tjscience tjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, @Saman-00

@ScarletKuro ScarletKuro merged commit 557ba89 into MudBlazor:dev Feb 17, 2024
2 of 4 checks passed
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants