Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudAvatarGroup: Add MaxAvatarsTemplate #7896

Merged
merged 7 commits into from Dec 19, 2023
Merged

MudAvatarGroup: Add MaxAvatarsTemplate #7896

merged 7 commits into from Dec 19, 2023

Conversation

Kaerlon
Copy link
Contributor

@Kaerlon Kaerlon commented Dec 13, 2023

Description

Adds a MaxAvatarTemplate prorerty to MudAvatarGroup.

I want to customize MaxAvatar to allow click-events, replacement with an image and more.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement New feature or request PR: needs review labels Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b40bba) 87.41% compared to head (e70d69e) 87.39%.
Report is 25 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7896      +/-   ##
==========================================
- Coverage   87.41%   87.39%   -0.03%     
==========================================
  Files         389      392       +3     
  Lines       11422    11602     +180     
  Branches     2299     2329      +30     
==========================================
+ Hits         9985    10140     +155     
- Misses        940      950      +10     
- Partials      497      512      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

ScarletKuro commented Dec 13, 2023

Hi.
Can you add a bUnit test please, to check that the custom render fragments gets rendered and the

 <MudAvatar Class="@MaxAvatarClassname" Color="@MaxColor" Size="@MaxSize" Variant="@MaxVariant" Rounded="@MaxRounded" Square="@MaxSquare" Elevation="@MaxElevation">
                @($"+{_avatars.Count - Max}")
</MudAvatar>

doesn't.

@henon thoughts?

@henon
Copy link
Collaborator

henon commented Dec 18, 2023

Hi, before merging I noticed that it would be better to name the template MaxAvatarsTemplate with an extra s. Could you rename it, then it can be merged.

@henon henon changed the title MudAvatarGroup: Added template for MaxAvatar MudAvatarGroup: Add MaxAvatarsTemplate Dec 18, 2023
@ScarletKuro
Copy link
Member

Hi, before merging I noticed that it would be better to name the template MaxAvatarsTemplate with an extra s. Could you rename it, then it can be merged.

You mean MaxAvatarsTemplateS? Are you sure about this one? In our codebase we use everywhere XYZTemplate.

@henon
Copy link
Collaborator

henon commented Dec 18, 2023

No I mean MaxAvatarsTemplate not MaxAvatarTemplate as it is now

@henon henon merged commit 12c563e into MudBlazor:dev Dec 19, 2023
2 of 3 checks passed
@henon
Copy link
Collaborator

henon commented Dec 19, 2023

Thanks @Kaerlon !

biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
* MudAvatarGroup: Added MaxAvatarsTemplate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants