Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X Icon Fix #8158

Merged
merged 1 commit into from Feb 10, 2024
Merged

X Icon Fix #8158

merged 1 commit into from Feb 10, 2024

Conversation

mckaragoz
Copy link
Member

@mckaragoz mckaragoz commented Feb 10, 2024

Description

Fixed newly added X icon (#8135). Now shows properly with 0 0 24 24 viewbox.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Feb 10, 2024
@ScarletKuro ScarletKuro self-requested a review February 10, 2024 17:32
@ScarletKuro
Copy link
Member

Ekran_goruntusu_2024-02-10_203259

@ScarletKuro ScarletKuro merged commit e8b0760 into MudBlazor:dev Feb 10, 2024
4 checks passed
@ScarletKuro ScarletKuro removed their request for review February 10, 2024 17:35
@marknoble
Copy link
Contributor

Ekran_goruntusu_2024-02-10_203259

How did you generate this screenshot from the branch?

@mckaragoz
Copy link
Member Author

mckaragoz commented Feb 10, 2024

How did you generate this screenshot from the branch?

You can run the project on your IDE. And dev.mudblazor.com always shows the latest commit.

@marknoble
Copy link
Contributor

dev.mudblazor.com

Ok, thanks. I can confirm the corrected icon at: https://dev.mudblazor.com/features/icons#icons

What about before the change is accepted though while it's still in your PR branch?

@ScarletKuro
Copy link
Member

ScarletKuro commented Feb 10, 2024

What about before the change is accepted though while it's still in your PR branch?

You can run the MudBlazor.Docs.WasmHost project from your IDE and you will have the docs locally with your changes. When you open the MudBlazor.sln this project is included by default.

biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants