Skeleton: Allow changes after initialization #8178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
henon
approved these changes
Feb 15, 2024
henon
changed the title
henon
changed the title
|
@VStefanWeber thanks! |
|
Thanks, it's much clean now. |
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
* Skeleton: Fix applying style after initialization * Skeleton: Add more unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skeleton applies new styles after initialization now. Before the skeleton styles were applied just once at initialization and no changes were possible afterwards.
How Has This Been Tested?
I added new unit test module (none was existing for skeleton before). It contains three tests which test the parameters Width, Height, Style after initialization and after a further update of the parameter afterwards.
The tests will fail without the fix.
Types of changes
Checklist:
dev).