-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudButton: Fix hover effect remaining after touch #8188
Conversation
Thank you @danielchalmers ! |
This might have broken button background color on mobile: #7742 (comment) |
@danielchalmers will you be able to fix the regression until end of the week? We'd have to revert otherwise as this seems to affect quite a few people judging on the issues. |
Sure I'll look into it further today, but I didn't write the original style so not super familiar. Would make sense to revert in the meantime. I added more info in #8240. |
It should have been applied to more than just the button anyway; menu items etc. |
@henon What do you use to format the .scss files? Adding # CSS pre-processor
[*.scss]
indent_size = 4
insert_final_newline = true to the .editorconfig still makes a decent number of changes which makes it a little difficult to add new hover effects while matching the format of each file. I could format them all using that but I doubt you want all your scss files changed. EDIT: Check out #8249 to see what it would look like. Feel free to close, I just wanted to show you. |
…#8188)" (MudBlazor#8247) This reverts commit 5052377.
Description
Resolves #7742 by implementing the proposed solution.
How Has This Been Tested?
Just visually
Types of changes
Before
Video.mp4
After
Video2.mp4
Checklist:
dev
).