Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudButton: Fix hover effect remaining after touch #8188

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

danielchalmers
Copy link
Contributor

@danielchalmers danielchalmers commented Feb 17, 2024

Description

Resolves #7742 by implementing the proposed solution.

How Has This Been Tested?

Just visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Before

Video.mp4

After

Video2.mp4

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers danielchalmers changed the title Fix hover effect remaining after touch MudButton: Fix hover effect remaining after touch Feb 17, 2024
@ScarletKuro ScarletKuro added the bug Something does not work as intended/expected label Feb 17, 2024
@henon henon merged commit 5052377 into MudBlazor:dev Feb 19, 2024
4 checks passed
@henon
Copy link
Collaborator

henon commented Feb 19, 2024

Thank you @danielchalmers !

@henon
Copy link
Collaborator

henon commented Feb 20, 2024

This might have broken button background color on mobile: #7742 (comment)

@henon
Copy link
Collaborator

henon commented Feb 26, 2024

@danielchalmers will you be able to fix the regression until end of the week? We'd have to revert otherwise as this seems to affect quite a few people judging on the issues.

@danielchalmers
Copy link
Contributor Author

@danielchalmers will you be able to fix the regression until end of the week? We'd have to revert otherwise as this seems to affect quite a few people judging on the issues.

@henon

Sure I'll look into it further today, but I didn't write the original style so not super familiar. Would make sense to revert in the meantime. I added more info in #8240.

@danielchalmers
Copy link
Contributor Author

It should have been applied to more than just the button anyway; menu items etc.

@danielchalmers
Copy link
Contributor Author

danielchalmers commented Feb 26, 2024

@henon What do you use to format the .scss files? Adding

# CSS pre-processor
[*.scss]
indent_size = 4
insert_final_newline = true

to the .editorconfig still makes a decent number of changes which makes it a little difficult to add new hover effects while matching the format of each file.

I could format them all using that but I doubt you want all your scss files changed.

EDIT: Check out #8249 to see what it would look like. Feel free to close, I just wanted to show you.

This was referenced Feb 26, 2024
@danielchalmers danielchalmers deleted the touch-hover branch April 4, 2024 23:45
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accidental break bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Icon)Button :hover css doesn't clear on touch devices
3 participants