Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageBox: Add "mud-message-box" class #8189

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

Adds a class to MudMessageBox so you can apply styles to it and its children.

How Has This Been Tested?

none

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement New feature or request PR: needs review labels Feb 17, 2024
@danielchalmers
Copy link
Contributor Author

Replaces #7807 because I broke the branch

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee80e01) 88.25% compared to head (0d32455) 88.24%.
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8189      +/-   ##
==========================================
- Coverage   88.25%   88.24%   -0.01%     
==========================================
  Files         394      394              
  Lines       11742    11753      +11     
  Branches     2377     2380       +3     
==========================================
+ Hits        10363    10372       +9     
- Misses        854      855       +1     
- Partials      525      526       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

ScarletKuro commented Feb 17, 2024

Just visually from another project. Unsure what tests would be added.

The test would be basically to test if the specified class is applied in the html, a really simple test.

@danielchalmers
Copy link
Contributor Author

danielchalmers commented Feb 17, 2024

Just visually from another project. Unsure what tests would be added.

The test would be basically to test if the specified class is applied in the html, a really simple test.

@ScarletKuro

That makes sense! Are the tests I just updated appropriate?

@henon henon merged commit 5758e55 into MudBlazor:dev Feb 19, 2024
3 checks passed
@henon
Copy link
Collaborator

henon commented Feb 19, 2024

Thanks!

danielchalmers added a commit to danielchalmers/JournalApp that referenced this pull request Mar 12, 2024
danielchalmers added a commit to danielchalmers/JournalApp that referenced this pull request Mar 12, 2024
@danielchalmers danielchalmers deleted the mud-message-box-class branch April 4, 2024 23:45
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
* Add mud-message-box class

* Add mud-message-box to tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants