New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudStack: Add Wrap Property #8290
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8290 +/- ##
==========================================
+ Coverage 88.54% 88.62% +0.08%
==========================================
Files 400 405 +5
Lines 12090 12154 +64
Branches 2427 2428 +1
==========================================
+ Hits 10705 10772 +67
+ Misses 855 853 -2
+ Partials 530 529 -1 ☔ View full report in Codecov by Sentry. |
Hi. Thanks for PR. |
Curious, what does |
MDN says this: |
src/MudBlazor.Docs/Pages/Components/Stack/Examples/StackWrappingExample.razor
Outdated
Show resolved
Hide resolved
src/MudBlazor.Docs/Pages/Components/Stack/Examples/StackWrappingExample.razor
Outdated
Show resolved
Hide resolved
I also think it would make sense to add the xml doc for the enum values and copy the description from here: and add some description to the enum c;lass as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side.
Thanks @skyslide22 ! |
It can be also done with simple |
I had some issues with setting Class="" & Style="" in a MVC project where the blazor components get rerendered after OnAfterInitialized and the state is not preserved for some reason, so the class and styles are removed after first/second render. |
Do you have the code? It can be either a bug on our side or mistake on your side. |
* Stack: add wrap property * Add/Remove indentation & newlines * Add unit tests for stack wrap functionality * rm empty spaces after ; * rm unecessary using statement * Add descriptions to Wrap enum values --------- Co-authored-by: n.wallura@live-icom.com <n.wallura@live-icom.com>
* Stack: add wrap property * Add/Remove indentation & newlines * Add unit tests for stack wrap functionality * rm empty spaces after ; * rm unecessary using statement * Add descriptions to Wrap enum values --------- Co-authored-by: n.wallura@live-icom.com <n.wallura@live-icom.com>
* Stack: add wrap property * Add/Remove indentation & newlines * Add unit tests for stack wrap functionality * rm empty spaces after ; * rm unecessary using statement * Add descriptions to Wrap enum values --------- Co-authored-by: n.wallura@live-icom.com <n.wallura@live-icom.com>
* Stack: add wrap property * Add/Remove indentation & newlines * Add unit tests for stack wrap functionality * rm empty spaces after ; * rm unecessary using statement * Add descriptions to Wrap enum values --------- Co-authored-by: n.wallura@live-icom.com <n.wallura@live-icom.com>
Added the optional
flex-wrap: wrap|nowrap|wrap-reverse
to the<Stack />
component.Docs section added.