Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudDataGrid: Respect indeterminate state in select-all checkboxes #8317

Conversation

Qwertyluk
Copy link
Contributor

@Qwertyluk Qwertyluk commented Mar 8, 2024

Description

Resolves #6553

How Has This Been Tested?

Added a unit test to ensure that a state (including indeterminate state) of select-all checkboxes change correctly based on the number of selected items in the data grid.
Also conducted manual testing of the changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

image

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.50%. Comparing base (0dcc84c) to head (9161807).

Files Patch % Lines
src/MudBlazor/Components/DataGrid/HeaderContext.cs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           dev    #8317       +/-   ##
========================================
+ Coverage     0   89.50%   +89.50%     
========================================
  Files        0      411      +411     
  Lines        0    11848    +11848     
  Branches     0     2362     +2362     
========================================
+ Hits         0    10604    +10604     
- Misses       0      715      +715     
- Partials     0      529      +529     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tjscience tjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Appreciate it, @Qwertyluk!

@ScarletKuro ScarletKuro added breaking change API change API that needs approval labels Apr 3, 2024
@ScarletKuro
Copy link
Member

Added to v7.0.0 Migration Guide #8447
since this PR changed public api type from bool to bool?.

@ScarletKuro ScarletKuro merged commit e6741bb into MudBlazor:dev Apr 3, 2024
4 checks passed
@ScarletKuro
Copy link
Member

@Qwertyluk thanks.

biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
…dBlazor#8317)

Co-authored-by: Pawel Krzyzak <Pawel.Krzyzak@krolldiscovery.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change API that needs approval breaking change bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudDataGrid: Select-all checkbox doesn't respect indeterminate state
3 participants