MudTextField: Fix scrollbars appearing with AutoGrow on scaled displays due to rounding error #8329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Video2.mp4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8329 +/- ##
==========================================
- Coverage 88.65% 88.64% -0.02%
==========================================
Files 407 407
Lines 12169 12175 +6
Branches 2430 2429 -1
==========================================
+ Hits 10789 10793 +4
- Misses 852 853 +1
- Partials 528 529 +1 ☔ View full report in Codecov by Sentry. |
ScarletKuro
reviewed
Mar 10, 2024
|
Related to AutoGrow: #8234 |
henon
changed the title
|
Thanks @danielchalmers |
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
…ys due to rounding error (MudBlazor#8329)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would notice scrollbars appearing that could barely be moved, specifically on my Android phone with scaling >100%.
Similar fix in #8235 for unrestricted text fields and I believe this PR conclusively fixes it for fields that have MaxLines too.
How Has This Been Tested?
visually
Types of changes
scrollHeight is rounded while line-height and others aren't. This causes subpixel inaccuracy resulting in useless scrollbars.
Before:
After:
Now we don't show a scrollbar at all unless we EXCEED the specified (fractional) max height.
Related:
Checklist:
dev).