MudDateRangePicker: Ignore timestamp when setting day classes #8342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8342 +/- ##
==========================================
+ Coverage 88.62% 88.69% +0.06%
==========================================
Files 407 407
Lines 12175 12176 +1
Branches 2429 2430 +1
==========================================
+ Hits 10790 10799 +9
+ Misses 855 853 -2
+ Partials 530 524 -6 ☔ View full report in Codecov by Sentry. |
ScarletKuro
reviewed
Mar 12, 2024
src/MudBlazor/Components/DatePicker/MudDateRangePicker.razor.cs
Outdated
Show resolved
Hide resolved
ScarletKuro
approved these changes
Mar 12, 2024
|
Thanks @Anu6is |
danielchalmers
pushed a commit
to danielchalmers/MudBlazor
that referenced
this pull request
Mar 13, 2024
…zor#8342) * MudDateRangePicker: Ignore timestamp when definig selected date range classes * make null check more readable
danielchalmers
pushed a commit
to danielchalmers/MudBlazor
that referenced
this pull request
Mar 13, 2024
…zor#8342) * MudDateRangePicker: Ignore timestamp when definig selected date range classes * make null check more readable
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
…zor#8342) * MudDateRangePicker: Ignore timestamp when definig selected date range classes * make null check more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting the CSS classes for the selected dates in the date range picker, ignore any timestamps included in the start and end dates for the
DateRange.Resolves #8339.
Also, while not mentioned in the issue, the error meant that the start date was not included in the selected date range.
How Has This Been Tested?
Tested using unit tests and unit test viewer.
Added new test cases and test viewer components.
Types of changes
Checklist:
dev).