Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mistaken CSS Reordering #8345

Merged
merged 1 commit into from Mar 12, 2024
Merged

Conversation

mckaragoz
Copy link
Member

@mckaragoz mckaragoz commented Mar 12, 2024

Description

Fixes: #8144
Fixes: #7948 (comment)

This returns the old reordering in MudBlazor.scss file which was broken with MudToggleGroup PR.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@ScarletKuro ScarletKuro added bug Something does not work as intended/expected accidental break labels Mar 12, 2024
@ScarletKuro ScarletKuro requested a review from henon March 12, 2024 20:38
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.66%. Comparing base (3eee937) to head (1a14210).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8345      +/-   ##
==========================================
- Coverage   88.68%   88.66%   -0.02%     
==========================================
  Files         407      407              
  Lines       12179    12179              
  Branches     2431     2431              
==========================================
- Hits        10801    10799       -2     
- Misses        855      856       +1     
- Partials      523      524       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mckaragoz
Copy link
Member Author

Ekran görüntüsü 2024-03-12 233034

Fixes the DatePicker visual crash.

@mikes-gh
Copy link
Contributor

Checking now

@mikes-gh
Copy link
Contributor

Double checked file order and downloaded PR to visually test DatePicker

@mikes-gh mikes-gh merged commit 85df2ae into MudBlazor:dev Mar 12, 2024
4 checks passed
@henon
Copy link
Collaborator

henon commented Mar 12, 2024

Thank you @mckaragoz and @mikes-gh !

danielchalmers pushed a commit to danielchalmers/MudBlazor that referenced this pull request Mar 13, 2024
danielchalmers pushed a commit to danielchalmers/MudBlazor that referenced this pull request Mar 13, 2024
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accidental break bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudBlazor.min.css styles order changed in 6.12.0
4 participants