New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Mistaken CSS Reordering #8345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScarletKuro
added
bug
Something does not work as intended/expected
accidental break
labels
Mar 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8345 +/- ##
==========================================
- Coverage 88.68% 88.66% -0.02%
==========================================
Files 407 407
Lines 12179 12179
Branches 2431 2431
==========================================
- Hits 10801 10799 -2
- Misses 855 856 +1
- Partials 523 524 +1 ☔ View full report in Codecov by Sentry. |
Checking now |
Double checked file order and downloaded PR to visually test DatePicker |
Thank you @mckaragoz and @mikes-gh ! |
danielchalmers
pushed a commit
to danielchalmers/MudBlazor
that referenced
this pull request
Mar 13, 2024
danielchalmers
pushed a commit
to danielchalmers/MudBlazor
that referenced
this pull request
Mar 13, 2024
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #8144
Fixes: #7948 (comment)
This returns the old reordering in MudBlazor.scss file which was broken with MudToggleGroup PR.
How Has This Been Tested?
Types of changes
Checklist:
dev
).