Use ActionDefault as the base for ActionDefaultHover #8405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the static Colors.Shades.Black Fixes MudBlazor#2792
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8405 +/- ##
==========================================
- Coverage 88.87% 88.86% -0.02%
==========================================
Files 414 414
Lines 12291 12292 +1
Branches 2455 2455
==========================================
- Hits 10924 10923 -1
- Misses 837 838 +1
- Partials 530 531 +1 ☔ View full report in Codecov by Sentry. |
|
you can see this in action easily by changing the theme in Docs and checking the hover on the navbar |
Garderoben
approved these changes
Mar 21, 2024
danielchalmers
added a commit
to danielchalmers/JournalApp
that referenced
this pull request
Mar 28, 2024
Hover color was changed in MudBlazor/MudBlazor#8405 which pushed me to make some style changes: - Header now uses pure white text instead of grayish to improve contrast and accessibility - Emoji button now has hover and items are denser to fit better on phone
This was referenced Mar 29, 2024
danielchalmers
added a commit
to danielchalmers/JournalApp
that referenced
this pull request
Mar 31, 2024
- Filled buttons always have the hover style - Hover effects are too faint on the header buttons Both are a side effect of MudBlazor/MudBlazor#8405 But we still get to keep the "sticky" hover fix in 6.18.0.
danielchalmers
added a commit
to danielchalmers/JournalApp
that referenced
this pull request
Apr 2, 2024
Hover color was changed in MudBlazor/MudBlazor#8405 which pushed me to make some style changes: - Header now uses pure white text instead of grayish to improve contrast and accessibility - Emoji button now has hover and items are denser to fit better on phone
danielchalmers
added a commit
to danielchalmers/JournalApp
that referenced
this pull request
Apr 2, 2024
- Filled buttons always have the hover style - Hover effects are too faint on the header buttons Both are a side effect of MudBlazor/MudBlazor#8405 But we still get to keep the "sticky" hover fix in 6.18.0.
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
Instead of the static Colors.Shades.Black Fixes MudBlazor#2792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of the static Colors.Shades.Black
Fixes #2792
How Has This Been Tested?
visually
Types of changes
Checklist:
dev).