Update icons and remove obsolete API

[danielchalmers]

Description

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• The PR is submitted to the correct branch (dev).
• My code follows the code style of this project.
• I've added relevant tests.

[danielchalmers]

@henon script did not seem to include EditDocument

#7479 (comment)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (a047ed3) to head (8d86312).
Report is 50 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #8421      +/-   ##
==========================================
+ Coverage   88.88%   89.29%   +0.40%     
==========================================
  Files         414      411       -3     
  Lines       12294    11900     -394     
  Branches     2455     2356      -99     
==========================================
- Hits        10928    10626     -302     
+ Misses        836      751      -85     
+ Partials      530      523       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[henon]

Interesting, I wouldn't have expected that so many icons changed. Did you do some random control samples if the changed icons look OK?

[ScarletKuro]

I think the problem is that when you open the official https://fonts.google.com/icons website, select "Material Icons" (old ones) and select "Filled" you will see a request going here https://fonts.googleapis.com/css2?family=Material+Icons&v=1711197937047
and then it fetches https://fonts.gstatic.com/s/materialicons/v141/flUhRq6tzZclQEJ-Vdg-IuiaDsNc.woff2
So it seems now the old material icons is a font too and they do not provide the metadata for new icons here https://fonts.google.com/metadata/icons so it seems it's not really possible to fetch them now automatically?

Interesting, I wouldn't have expected that so many icons changed. Did you do some random control samples if the changed icons look OK?

This is normal, google was always fixing the existing icons, and considering that it was run last time on 2022/12/28 by me... I'm not surprised.

[ScarletKuro]

Tho what's weird that I do see the "edit_document" here https://github.com/google/material-design-icons/tree/master/symbols/web
and it's svg. Maybe they just do not update the metadata anymore, it's hard to say, would be easier to ask google in the https://github.com/google/material-design-icons/issues

[ScarletKuro]

I found this: https://fonts.google.com/metadata/icons?key=material_symbols&incomplete=true
but the JSON looks corrupted, look at the start )]}' i do see the "edit_document", but this json also includes Material Symbols Outlined, Material Symbols Rounded, Material Symbols Sharp that we do not really need.

[ScarletKuro]

but the JSON looks corrupted, look at the start )]}'

Nvm about this, the original one https://fonts.google.com/metadata/icons has the same thing

[ScarletKuro]

It doesn't seems like we can just replace the url with the new one.
for example in old one the 10k icon says that all families are supported, but in new one it says the 10k doesn't support outlined, round, sharp, two tone and our script will try to fetch the sharp one /s/i/materialiconssharp/10k/v256/24px.svg which will lead to exception.
It doesn't exist for v256, but exist for v10: http://fonts.gstatic.com/s/i/materialiconssharp/10k/v10/24px.svg
The script would need to look the "unsupported_families".

[danielchalmers]

Is this relevant?

Remove the backwards compatibility forwarding structures for our Icons

https://github.com/MudBlazor/MudBlazor/projects/13#card-82213304

[ScarletKuro]

Is this relevant?

Remove the backwards compatibility forwarding structures for our Icons

https://github.com/MudBlazor/MudBlazor/projects/13#card-82213304

Yes, we need to remove all icons from obsolete folder https://github.com/MudBlazor/MudBlazor/tree/dev/src/MudBlazor/Icons/Obsolete
And update the script to not generate that folder

[danielchalmers]

Yes, we need to remove all icons from obsolete folder https://github.com/MudBlazor/MudBlazor/tree/dev/src/MudBlazor/Icons/Obsolete And update the script to not generate that folder

@ScarletKuro

Do you want me to do that in this PR? Did you figure out how to get the new icons?

[ScarletKuro]

Do you want me to do that in this PR?

You can do the removal PR, i don't mind, just don't forget to update the powershell script so it wouldn't generate them back.

Did you figure out how to get the new icons?

I said here #8421 (comment), but that would require to improve the script, currently there are more important things to do than just add few missing icons

[danielchalmers]

@ScarletKuro obsolete icons are gone

[ScarletKuro]

LGTM

[henon]

v7.0.0 Migration Guide #8447