-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudDialog: Fix some params not passed when inline #8424
Conversation
👀 #6174 may optimize the IsVisible setter |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8424 +/- ##
==========================================
+ Coverage 88.80% 88.89% +0.08%
==========================================
Files 414 414
Lines 12294 12297 +3
Branches 2455 2455
==========================================
+ Hits 10918 10931 +13
+ Misses 844 836 -8
+ Partials 532 530 -2 ☔ View full report in Codecov by Sentry. |
LGTM, thanks for looking into it. |
Thanks @danielchalmers |
Would be nice, it should be really easy with |
I’ve reported a couple more issues that I could work on, but there are instructions not to unless agreed upon. Perhaps this information should be removed? |
@BieleckiLtd that message was clarified recently in #8321 due to what you're expressing I think PRs are very encouraged. It was just worded wrong before. |
Description
Fixes #4719
Fixes #6145
Some parameters were not being set which was notably causing the OnBackdropClick callback to not be fired after the dialog was shown by IsVisible.
How Has This Been Tested?
Types of changes
Checklist:
dev
).