-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v7: Drop .NET6 as supported framework. #8441
Conversation
- Drops support for .NET 6 as done in MudBlazor#7134 but drops .NET 7 as well as support ends in May, before .NET 6 - PackageProjectUrl is now https - Updates Minimal Prerequisites to Compile from Source - README - Minor cleanup - Combines `6.0.x` and `6.1.x` into `6.x.x` for simplicity - Adds `7.x.x` for the new branch and only states support for .NET 8 - Adds a link to the render modes page to avoid questions - Adds new text to Contributing including from the issue template
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8441 +/- ##
==========================================
+ Coverage 88.77% 88.79% +0.02%
==========================================
Files 416 416
Lines 12372 12307 -65
Branches 2459 2447 -12
==========================================
- Hits 10983 10928 -55
+ Misses 859 842 -17
- Partials 530 537 +7 ☔ View full report in Codecov by Sentry. |
Hi. What everyone thinks of dropping .net7? My view: For me it's not about when the supports ends, but about features. Blazor develops fast, and .NET7 brought new binding that can make our life better and we need them. The .NET8 didn't bring any useful public API for razor class library. |
@danielchalmers Even if we did remove net7 this PR will have to remain open until EOS for net7 and a bit longer after that. As @ScarletKuro says we would need to solve trymudblazor running on net8 only. You are welcome to look at that repo to see if you can solve it. It will probably take you a while to understand the history of the original fork and how we have modified it over the years. We've all looked at it and decided ATM its a lot of work. But a new set of eyes might help. |
@danielchalmers can you reclassify this PR in dropping only .net6 as we all agreed in discord back then when this was done: #7134? |
I believe that if Microsoft isn't going to support it, you shouldn't either. If someone wants to stay on .NET 7 they don't have to go to a new major version of MudBlazor when 6.x.x is still supported. Dropping .NET 7 mid-cycle would be another breaking change so would support a dead version til v8. We should be able to get TryMudBlazor to .NET 8 soon - MudBlazor/TryMudBlazor#121. |
.NET 7 EOS is May 14, 2024 so very soon. We will be making a lot more breaking changes in the future. After v7 we'll soon go for v8, v9 and v10 as we have let ourselves become constrained by avoiding breaking changes for far too long. This has hindered innovation and improvement in the library so I wouldn't worry about having to do another breaking change soon ;). The idea of THE BIG BREAK has been abandoned. Instead we'll gradually break everything we need to break to make the lib better. I personally think it is a bit too soon to abandon net7 as dropping it forces everyone to also upgrade to net8 if they want the new features or fixes. And I don't see a huge merit of dropping it now. But in the end it is up to the team to decide. We had a preliminary decision against dropping net7 in the discord channel but not everyone participated at that time. We can make a final decision here in the issue @MudBlazor/contribution-team |
Please, do not drop .NET 7 support yet. |
@Yomodo Will you be on .NET 8 before Microsoft ends support for .NET 7? .NET 6 should be a more concerning drop considering it's supported longer and most enterprise will stick with LTS |
Hopefully, but can't say for certain. |
I added .net7 back to |
Link to guide: #8447 |
Co-authored-by: Artyom M <artem.melnikov@live.com>
Description
Part of #8435
6.0.x
and6.1.x
into6.x.x
for simplicity7.x.x
for the new branch and only states support for .NET7 and .NET 8How Has This Been Tested?
Types of changes
Checklist:
dev
).