Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix Color Picker example usage #8444 #8445

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Malgorad
Copy link
Contributor

Description

Fixes: #8444

How Has This Been Tested?

Via docs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Mar 24, 2024
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (867148b) to head (3925f0a).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8445      +/-   ##
==========================================
+ Coverage   88.73%   88.77%   +0.04%     
==========================================
  Files         416      416              
  Lines       12355    12355              
  Branches     2457     2457              
==========================================
+ Hits        10963    10968       +5     
+ Misses        860      857       -3     
+ Partials      532      530       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro requested a review from henon March 25, 2024 15:08
@ScarletKuro
Copy link
Member

ScarletKuro commented Mar 25, 2024

Hi.
Thanks for the PR.
Can you please post before and after the change, so we wouldn't need to pull the changes and test it locally.

@Malgorad
Copy link
Contributor Author

Hi. Thanks for the PR. Can you please post before and after the change, so we wouldn't need to pull the changes and test it locally.

Thank you for the advice and apologies for the inconvenience.

@danielchalmers
Copy link
Contributor

@ScarletKuro @henon

video2.mp4
video3.mp4

@henon henon merged commit 2c92dbc into MudBlazor:dev Apr 8, 2024
4 checks passed
@henon henon added docs Related to docs and removed bug Something does not work as intended/expected PR: needs review labels Apr 8, 2024
@henon
Copy link
Collaborator

henon commented Apr 8, 2024

Thanks!

@mikes-gh
Copy link
Contributor

mikes-gh commented Apr 8, 2024

@Malgorad Thanks a lot I noticed it the other day

biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Co-authored-by: Julian L <julian.litteck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Bug in the example usage of Color Picker
5 participants