-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudAutocomplete: Remove SearchFuncWithCancel, Add CancellationToken to SearchFunc #8490
MudAutocomplete: Remove SearchFuncWithCancel, Add CancellationToken to SearchFunc #8490
Conversation
…oken to SearchFunc
…oken to SearchFunc
…https://github.com/jperson2000/MudBlazor into feature/mudautocomplete-searchfunc-cancellationtoken
…oken to SearchFunc
…https://github.com/jperson2000/MudBlazor into feature/mudautocomplete-searchfunc-cancellationtoken
There are conflicts. Please merge dev to resolve them. Added to v7.0.0 Migration Guide #8447 |
Co-authored-by: Artyom M <artem.melnikov@live.com>
LGTM, just need to rebase and fix conflicts like henon said. |
…oken to SearchFunc
…https://github.com/jperson2000/MudBlazor into feature/mudautocomplete-searchfunc-cancellationtoken
…oken to SearchFunc
…https://github.com/jperson2000/MudBlazor into feature/mudautocomplete-searchfunc-cancellationtoken
…oken to SearchFunc
…https://github.com/jperson2000/MudBlazor into feature/mudautocomplete-searchfunc-cancellationtoken
…oken to SearchFunc
Alright, thanks again for all the reviews and feedback! I've rebased onto |
Next time please just merge |
And thanks for the contribution @jperson2000 ! |
…o SearchFunc (MudBlazor#8490) Co-authored-by: Jon Person <j.person@dodmarrow.org>
This breaking change removes the
SearchFuncWithCancel
method and moves theCancellationToken
functionality to theSearchFunc
method.Description
Recent changes to the MudTable
ServerData
method (PR 8407) led to a desire to use the same single-method pattern for other cancelable methods. This update:SearchFuncWithCancel
methodCancellationToken
parameter to theSearchFunc
methodCancellationToken
parameter.How Has This Been Tested?
Existing tests for
MudAutocomplete
were modified to include theCancellationToken
parameter.Types of changes
Checklist:
dev
).Notes for Reviewers
This should probably get a
v7
tag and be released with similar breaking changes toMudTable
in the works for #8447