Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudAutocomplete: Remove SearchFuncWithCancel, Add CancellationToken to SearchFunc #8490

Conversation

jperson2000
Copy link
Sponsor Contributor

@jperson2000 jperson2000 commented Mar 26, 2024

This breaking change removes the SearchFuncWithCancel method and moves the CancellationToken functionality to the SearchFunc method.

Description

Recent changes to the MudTable ServerData method (PR 8407) led to a desire to use the same single-method pattern for other cancelable methods. This update:

  • Removes the SearchFuncWithCancel method
  • Moves the CancellationToken parameter to the SearchFunc method
  • Updates all tests and examples to include the new CancellationToken parameter.

How Has This Been Tested?

Existing tests for MudAutocomplete were modified to include the CancellationToken parameter.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Notes for Reviewers

This should probably get a v7 tag and be released with similar breaking changes to MudTable in the works for #8447

@ScarletKuro ScarletKuro requested a review from henon March 27, 2024 10:55
@henon henon changed the title MudAutocomplete: Removed SearchFuncWithCancel, Added CancellationToken to SearchFunc MudAutocomplete: Remove SearchFuncWithCancel, Add CancellationToken to SearchFunc Mar 27, 2024
@henon henon added API change API that needs approval v7 New major MudBlazor version and removed PR: needs review labels Mar 27, 2024
@henon henon mentioned this pull request Mar 27, 2024
@henon
Copy link
Collaborator

henon commented Mar 27, 2024

There are conflicts. Please merge dev to resolve them.

Added to v7.0.0 Migration Guide #8447

@ScarletKuro
Copy link
Member

LGTM, just need to rebase and fix conflicts like henon said.

@jperson2000
Copy link
Sponsor Contributor Author

Alright, thanks again for all the reviews and feedback! I've rebased onto dev and added 1 commit to re-implement the new token parameter in MudBlazor.Docs\Shared\AppBar.razor.

@henon
Copy link
Collaborator

henon commented Mar 27, 2024

Next time please just merge dev, somehow rebasing with Visual Studio messes up the PR. You are done, however, so it doesn't really matter. Just so you know.

@henon henon merged commit ef34068 into MudBlazor:dev Mar 27, 2024
3 checks passed
@henon
Copy link
Collaborator

henon commented Mar 27, 2024

And thanks for the contribution @jperson2000 !

@jperson2000 jperson2000 deleted the feature/mudautocomplete-searchfunc-cancellationtoken branch April 18, 2024 23:16
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
…o SearchFunc (MudBlazor#8490)

Co-authored-by: Jon Person <j.person@dodmarrow.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change API that needs approval breaking change v7 New major MudBlazor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants