Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGrid : Fix sorting when there is Header row (#7645) #8504

Merged

Conversation

timlunev
Copy link
Contributor

Description

MudDataGrid has an issue with the HeaderCell component when the Header is added and there is no Column on a sort.
This PR fixes #7645

How Has This Been Tested?

A new DataGrid unit test was added to verify if sorting does not throw NullReferenceException and if sorting is still working as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.08%. Comparing base (5929972) to head (78283c7).
Report is 1 commits behind head on dev.

Files Patch % Lines
.../MudBlazor/Components/DataGrid/HeaderCell.razor.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8504      +/-   ##
==========================================
+ Coverage   89.03%   89.08%   +0.04%     
==========================================
  Files         411      411              
  Lines       12175    12173       -2     
  Branches     2431     2431              
==========================================
+ Hits        10840    10844       +4     
+ Misses        799      795       -4     
+ Partials      536      534       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

@henon I suggest to merge it without @tjscience review as it just fixed a null exception.

@ScarletKuro ScarletKuro requested a review from henon March 27, 2024 14:15
@henon henon merged commit 9725d48 into MudBlazor:dev Mar 28, 2024
3 of 4 checks passed
@henon
Copy link
Collaborator

henon commented Mar 28, 2024

Thanks @timlunev

biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudDatagrid: Sort broken if there's Header row
3 participants