Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix ScrollToTopTests #8507

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

ScarletKuro
Copy link
Member

Description

Test started to fail after this PR: #6061
Reason is that there are now multiple spans

How Has This Been Tested?

With the unit tests itself

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Mar 28, 2024
@ScarletKuro ScarletKuro changed the title Test: Fix ScrollToTopTests Tests: Fix ScrollToTopTests Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.34%. Comparing base (f979c2c) to head (05be80f).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8507      +/-   ##
==========================================
+ Coverage   89.05%   89.34%   +0.28%     
==========================================
  Files         411      411              
  Lines       12184    12146      -38     
  Branches     2433     2423      -10     
==========================================
+ Hits        10851    10852       +1     
+ Misses        798      760      -38     
+ Partials      535      534       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 9700485 into MudBlazor:dev Mar 28, 2024
4 checks passed
@ScarletKuro ScarletKuro deleted the test_fix branch March 28, 2024 01:52
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant