Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudOverlay: Fix two way binding with AutoClose=true #8513

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Mar 28, 2024

Description

Fixes: #8501

Before:
before

After
after

How Has This Been Tested?

Added new bUnit test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Mar 28, 2024
@ScarletKuro ScarletKuro changed the title MudOverlay: Fix two way binding MudOverlay: Fix two way binding with AutoClose=true Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (ce2aa03) to head (7cff922).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8513      +/-   ##
==========================================
+ Coverage   89.23%   89.29%   +0.05%     
==========================================
  Files         411      411              
  Lines       11901    11901              
  Branches     2356     2356              
==========================================
+ Hits        10620    10627       +7     
+ Misses        758      751       -7     
  Partials      523      523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 6c6f610 into MudBlazor:dev Mar 28, 2024
3 checks passed
@ScarletKuro ScarletKuro deleted the overlay_fix branch March 28, 2024 17:08
ScarletKuro added a commit that referenced this pull request Mar 28, 2024
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@Geccoka
Copy link
Contributor

Geccoka commented Jun 3, 2024

Any chance that this fix will be released to the v6 version?

@ScarletKuro
Copy link
Member Author

It is backported to v6 14faf34
but @henon needs to make a release, idk if CI/CD supports that as for now.

@mikes-gh
Copy link
Contributor

mikes-gh commented Jun 3, 2024

It is backported to v6 14faf34 but @henon needs to make a release, idk if CI/CD supports that as for now.

Yes the current actions support releasing v6 or preview v7

@henon
Copy link
Collaborator

henon commented Jun 3, 2024

v6.20.0 is released

@Geccoka
Copy link
Contributor

Geccoka commented Jun 3, 2024

v6.20.0 is released

That was fast, thank you. Tested the fix in my app, and it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudOverlay: AutoClose not updating the bound variable
4 participants