-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudOverlay: Fix two way binding with AutoClose=true #8513
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Something does not work as intended/expected
PR: needs review
labels
Mar 28, 2024
ScarletKuro
changed the title
MudOverlay: Fix two way binding
MudOverlay: Fix two way binding with AutoClose=true
Mar 28, 2024
ScarletKuro
force-pushed
the
overlay_fix
branch
from
March 28, 2024 16:31
68c000e
to
7cff922
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8513 +/- ##
==========================================
+ Coverage 89.23% 89.29% +0.05%
==========================================
Files 411 411
Lines 11901 11901
Branches 2356 2356
==========================================
+ Hits 10620 10627 +7
+ Misses 758 751 -7
Partials 523 523 ☔ View full report in Codecov by Sentry. |
ScarletKuro
added a commit
that referenced
this pull request
Mar 28, 2024
(cherry picked from commit 6c6f610)
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
Any chance that this fix will be released to the v6 version? |
v6.20.0 is released |
That was fast, thank you. Tested the fix in my app, and it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #8501
Before:
After
How Has This Been Tested?
Added new bUnit test.
Types of changes
Checklist:
dev
).