-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudPicker: Fix code style and naming issues #8517
Conversation
- Async postfix - Fixed naming for Classname properties - explicit modifiers - removed obsolete code Fix async behavior in HandleKeyDown event
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8517 +/- ##
==========================================
+ Coverage 89.29% 89.30% +0.01%
==========================================
Files 411 413 +2
Lines 11901 11905 +4
Branches 2356 2357 +1
==========================================
+ Hits 10627 10632 +5
Misses 751 751
+ Partials 523 522 -1 ☔ View full report in Codecov by Sentry. |
I edited your post with all public API renames if you don't mind. |
LGTM, just need to fix the formatting in one place. And thanks for the xmldocs, it was bothering me for a very long time |
Also resolves #8482 |
It looks like a dup. |
All done |
@ScarletKuro @henon is there something that I need to do for this pr? |
No, I'm waiting when @henon will review it. |
OK, just this #8517 (comment) left to be done then this can be merged |
All done, I did it already. |
Added to v7 Migration Guide #8447 |
Thanks @ArieGato |
|
||
<MudColorPicker Label="Basic Color Picker" @bind-Text="_colorValue" Style="@($"color: {_colorValue};")" Placeholder="Select Color" /> | ||
|
||
@code { | ||
private string _colorValue; | ||
private string _colorValue = "#000000"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, was this changed because of the MudColor constructor exception? I just fixed that so do you mind if I change this back in my PR? Hard to see now on dark theme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It threw a null ref exception.
Description
resolves #8489
resolves #8482
Classname
propertiesPublic API changes
MudColorPicker
MudBaseDatePicker
MudDatePicker
MudDateRangePicker
MudPicker
MudPickerContent
MudPickerToolbar
MudTimePicker
How Has This Been Tested?
Tested the Server Docs pages
Unit tests
Types of changes
Checklist:
dev
).