Code Cleanup: Improved Performance of MudComponentBase, ResizeObserver, and EventListener

[jperson2000]

Description

This update offers a minor improvement to performance by fixing four instances where Dictionary<T,U> lookups were being performed twice, as well as an optimization regarding unnecessary JSON deserialization. Regarding dictionary lookups, consider the following code:

Dictionary<string, string> values = new();
if(values.ContainsKey("test")) 
{ 
    return values["test"]; 
}

... in the above code, the values dictionary is being searched twice: once via ContainsKey then again via the indexer. By refactoring this to use TryGetValue, we can eliminate the second lookup, like this:

Dictionary<string, string> values = new();
if(values.TryGetValue("test", out var result)) 
{
    return result;
}

The four instances fixed for this PR improve the performance of the following properties and methods:

• MudComponentBase.FieldId
• MudDropZone.GetItemIndex()
• EventListener.OnEventOccur()
• ResizeObserver.OnSizeChanged()

Additionally, two optimizations were made to EventListener:

• The @event variable was being deserialized from JSON even if no handler existed to utilize it
• A new instance of JsonSerializerOptions was being made for each call when a static variable could have been reused

How Has This Been Tested?

This was tested by running unit tests after changes as well as by visually testing affected components such as testing page resizes, testing all form examples, and testing all MudDropZone examples. The EventListener was tested via the MudColorPicker example.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• The PR is submitted to the correct branch (dev).
• My code follows the code style of this project.
• I've added relevant tests.

Notes for Reviewers

I get a NullReferenceException when using the MudColorPicker for the first time because it's attempting to create a MudColor(null). I wonder if we can handle this a bit better somehow? (This error existed before this PR; I just noticed it during testing.)

[codecov]

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.77%. Comparing base (9b1ebb5) to head (493d0c2).

Files	Patch %	Lines
src/MudBlazor/Base/MudComponentBase.cs	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #8526   +/-   ##
=======================================
  Coverage   89.76%   89.77%           
=======================================
  Files         411      411           
  Lines       11824    11830    +6     
  Branches     2362     2362           
=======================================
+ Hits        10614    10620    +6     
  Misses        682      682           
  Partials      528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ScarletKuro]

Hi.
Sorry, can you resolve the conflicts?
I do think this change is important since TryGetValue is much more performant than ContainsKey("test") -> values["test"].

[jperson2000]

Hi. Sorry, can you resolve the conflicts? I do think this change is important since TryGetValue is much more performant than ContainsKey("test") -> values["test"].

You bet; I've just resolved the 2 conflicts

[henon]

Thanks @jperson2000