Table: Fix selection loss when applying filters and using Items property #8538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename multiselect test for ServerData
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8538 +/- ##
==========================================
+ Coverage 89.50% 89.54% +0.04%
==========================================
Files 411 411
Lines 11832 11832
Branches 2349 2349
==========================================
+ Hits 10590 10595 +5
+ Misses 718 715 -3
+ Partials 524 522 -2 ☔ View full report in Codecov by Sentry. |
|
@ralvarezing can you rebase / merge against latest changes? The datepicker tests were fixed. |
Perfect! done |
henon
changed the title
|
Thanks @ralvarezing |
danielchalmers
pushed a commit
to danielchalmers/MudBlazor
that referenced
this pull request
Apr 2, 2024
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The multiselect were being cleared when a filter or page changes using Items.
This was caused because when evaluating if the disposed table item is in the table, was evaluating against the FilteredItems instead of Items.
Because of this, when a filter was applied, all items that didn't match the filter, were consider NOT to be in the table, and being removed from the SelectedItems.
A similar bug was fixed in #7914, but when the data source is ServerData.
fixes #7535
How Has This Been Tested?
Added test TableMultiSelectItemsTest1_PageChange
Added test TableMultiSelectItemsTest1_FilterChange
Types of changes
Checklist:
dev).