Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateRangePicker: Fix tests - update selected range to use future dates #8543

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

Anu6is
Copy link
Contributor

@Anu6is Anu6is commented Apr 1, 2024

Description

By default the initial calendar shows the current month and next month. The existing tests use a range of 7 days in the past to the present day. This resulted in the possibility of the start date being in the previous month when the current day is within the first week of the current month. This causes tests to fail since mud-range-start-selected isn't visible (previous month isn't visible, only current and next)

How Has This Been Tested?

Visually with the test view and with the unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've updated relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.39%. Comparing base (8acb6c5) to head (3643016).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #8543   +/-   ##
=======================================
  Coverage   89.38%   89.39%           
=======================================
  Files         413      413           
  Lines       11865    11865           
  Branches     2354     2354           
=======================================
+ Hits        10606    10607    +1     
+ Misses        737      736    -1     
  Partials      522      522           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 0fe4f81 into MudBlazor:dev Apr 1, 2024
5 checks passed
@Anu6is Anu6is deleted the Tests-DateRantePicker-Fix branch April 12, 2024 12:39
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants