Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudFileUpload: Make FileUploadButtonTemplateContext.ClearAsync required #8547

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Apr 1, 2024

Description

This improves #6535
It was already meant to be always set by the FileUploadButtonTemplateContext and the nullable was surpressed with the null! annotation, but it's not required anymore with the required keyword. Now we can use it because of .net6 drop, we could use it before but it would require a special polifyll.

It slightly breaking in terms if someone used this class by himself, but usually this was totally managed by the FileUploadButtonTemplateContext.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (6ae6b98) to head (107b1cb).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8547      +/-   ##
==========================================
- Coverage   89.51%   89.47%   -0.05%     
==========================================
  Files         411      411              
  Lines       11845    11845              
  Branches     2351     2351              
==========================================
- Hits        10603    10598       -5     
- Misses        721      724       +3     
- Partials      521      523       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro added refactor Refactoring of code. No bug fixes or new features API change API that needs approval and removed PR: needs review labels Apr 1, 2024
@ScarletKuro ScarletKuro merged commit f06efcb into MudBlazor:dev Apr 1, 2024
5 checks passed
@ScarletKuro ScarletKuro deleted the readonly branch April 1, 2024 20:49
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change API that needs approval breaking change refactor Refactoring of code. No bug fixes or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant