Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MudTabs: Fix overflow when using high border radius values #8561

Merged
merged 1 commit into from
Apr 4, 2024
Merged

MudTabs: Fix overflow when using high border radius values #8561

merged 1 commit into from
Apr 4, 2024

Conversation

Lyrapuff
Copy link
Contributor

@Lyrapuff Lyrapuff commented Apr 3, 2024

Description

Fixes visual overflow when hovering over rounded MudTabs

How Has This Been Tested?

visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Before:
image_2024-04-03_16-47-42

After:
image_2024-04-03_16-48-13

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 3, 2024
@danielchalmers
Copy link
Contributor

Do you have some code I can try to see the difference like a https://try.mudblazor.com?

@Lyrapuff
Copy link
Contributor Author

Lyrapuff commented Apr 4, 2024

Do you have some code I can try to see the difference like a https://try.mudblazor.com?

Sure
https://try.mudblazor.com/snippet/wawoOoOSUOcoYQSo

@ScarletKuro ScarletKuro requested a review from henon April 4, 2024 17:17
@henon henon merged commit e0a8e98 into MudBlazor:dev Apr 4, 2024
5 checks passed
@henon
Copy link
Collaborator

henon commented Apr 4, 2024

Thanks!

biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@Lyrapuff @biegehydra
MudTabs: Fix overflow when using high border radius values (MudBlazor…
090f10d 
…#8561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielchalmers danielchalmers danielchalmers approved these changes

@ScarletKuro ScarletKuro ScarletKuro approved these changes

@henon henon Awaiting requested review from henon

Assignees
No one assigned
Labels
bug Something does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lyrapuff @danielchalmers @henon @ScarletKuro