Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Components: Remove obsolete API #8564

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

@ScarletKuro gave me this list:
MudBooleanInput.cs, DialogService.cs, IFormComponent.cs, ScrollManager.cs, MudAvatar.razor.cs, MudFormComponent.cs, MudDataGrid.razor.cs

This PR takes care of most of them and does some light code cleanup as well since those files will be conflicted anyway.

MudAvatar and MudDataGrid will come after this and #8562 have been merged.

#8472 will help with future removals + cleanups like this

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers
Copy link
Contributor Author

Let me know of any more obsoletes to remove in the next PR

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (e6741bb) to head (11b1a29).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8564      +/-   ##
==========================================
+ Coverage   89.52%   89.75%   +0.22%     
==========================================
  Files         411      411              
  Lines       11848    11818      -30     
  Branches     2362     2362              
==========================================
  Hits        10607    10607              
+ Misses        713      683      -30     
  Partials      528      528              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon mentioned this pull request Apr 4, 2024
@henon henon changed the title insert title here :) Several Components: Remove obsolete API Apr 4, 2024
Copy link
Collaborator

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to v7.0.0 Migration Guide #8447

@henon henon added API change API that needs approval v7 New major MudBlazor version and removed PR: needs review labels Apr 4, 2024
@henon henon merged commit c083dd3 into MudBlazor:dev Apr 4, 2024
5 checks passed
@henon
Copy link
Collaborator

henon commented Apr 4, 2024

Thanks!

@danielchalmers danielchalmers deleted the obsoletes0403 branch April 4, 2024 23:48
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change API that needs approval breaking change v7 New major MudBlazor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants