-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudColor: Add XML comments and make it serializable with STJ / NewtonsoftJson #8579
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8579 +/- ##
==========================================
+ Coverage 89.70% 89.78% +0.07%
==========================================
Files 411 411
Lines 11817 11840 +23
Branches 2362 2363 +1
==========================================
+ Hits 10600 10630 +30
+ Misses 689 682 -7
Partials 528 528 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really really dislike the idea of locking into one serializer. Why can't it work out of the box for all serializers? Please let me look into this more before merging
Btw I did some of that cleanup in my PRs so there will be conflicts
Because For it to make work with any serializers you need: only then this type will function properly and you won't have other junks in the serialized object aka HLS and |
@danielchalmers I added more supports, now it supports Newtonsoft as well and others that respect |
Great, thank you. Yeah, not ideal but I get the point. I don't think there's a nicer way of doing it. Other changes are great. Nice work |
I reverted |
Description
Fixes: #7688
Fixes: #3095
This makes it compatible only with STJ.
I know other Serializers exists like
Newtonsoft.Json
,YamlDotNet
, and many other binary ones.But I think think most customers are using the built in - STJ, and the issues were specifically talking about it. I think advanced user can workaround it with custom converters.
How Has This Been Tested?
New unit tests.
Types of changes
Checklist:
dev
).