Various Components: Rename DisableElevation to DropShadow
#8592
Conversation
henon
requested review from
ScarletKuro and
danielchalmers
and removed request for
ScarletKuro
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8592 +/- ##
==========================================
+ Coverage 89.82% 90.00% +0.17%
==========================================
Files 412 418 +6
Lines 11878 12029 +151
Branches 2364 2371 +7
==========================================
+ Hits 10670 10827 +157
+ Misses 681 667 -14
- Partials 527 535 +8 ☔ View full report in Codecov by Sentry. |
| @@ -206,7 +206,7 @@ | |||
| </div> | |||
| </div> | |||
| <div class="d-flex align-end flex-grow-1 pa-4"> | |||
| <MudButton Variant="Variant.Filled" Color="Color.Primary" FullWidth="true" DisableElevation="true">Pay now</MudButton> | |||
| <MudButton Variant="Variant.Filled" Color="Color.Primary" FullWidth="false" DropShadow="true">Pay now</MudButton> | |||
There was a problem hiding this comment.
Why did fullwidth change? Looks better?
There was a problem hiding this comment.
Oopsie, good catch, I think I inverted the wrong property here
| @namespace MudBlazor.Docs.Examples | ||
|
|
||
| <MudButtonGroup Color="Color.Primary" Variant="Variant.Filled" DisableElevation="@_disableElevation"> | ||
| <MudButtonGroup Color="Color.Primary" Variant="Variant.Filled" DropShadow="@_dropShadow"> | ||
| <MudButton>One</MudButton> | ||
| <MudButton>Two</MudButton> | ||
| <MudButton>Three</MudButton> | ||
| </MudButtonGroup> | ||
|
|
||
| <MudSwitch @bind-Value="_disableElevation" Label="Disable elevation" Color="Color.Primary" /> | ||
| <MudSwitch @bind-Value="_dropShadow" Label="Drop shadow" Color="Color.Primary" /> | ||
|
|
||
| @code { | ||
| private bool _disableElevation = true; | ||
| private bool _dropShadow = true; | ||
| } |
There was a problem hiding this comment.
Since the goal of that doc is to show deviation from the default behavior, drop shadow should be false, right?
|
Are you going to keep the |
|
Yes, Elevation makes sense with an int value. That is the main reason why I renamed DisableElevation to DropShadow. |
|
would it make sense if the elevation property could enable/disable it without the need for an extra boolean property? honestly not super familiar with the elevation stuff |
|
I think it is rare that elevation can be controlled directly. Mostly you set the elevation in the theme and it applies to all equally. That's why this would not be easy to change. |
Description
We want to move from
DisableSomethingto justSomethingorEnableSomethingdepending on the property. This PR tackles onlyDisableElevationand renames it toDropShadow. Of course default value and all invocations have been inverted.See #6131
How Has This Been Tested?
Types of changes
Checklist:
dev).