Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleGroup: Rename Outline to Outlined & Internal cleanup #8616

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

Please let me know if I did this right and if there's any more I should have changed.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers danielchalmers marked this pull request as ready for review April 9, 2024 18:04
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 89.87%. Comparing base (28bc599) to head (2df10fe).
Report is 13 commits behind head on dev.

Files Patch % Lines
...MudBlazor/Components/Toggle/MudToggleItem.razor.cs 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8616      +/-   ##
==========================================
+ Coverage   89.82%   89.87%   +0.04%     
==========================================
  Files         412      414       +2     
  Lines       11878    11911      +33     
  Branches     2364     2364              
==========================================
+ Hits        10670    10705      +35     
+ Misses        681      676       -5     
- Partials      527      530       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers danielchalmers changed the title ToggleGroup: Rename class properties and Outline to meet conventions ToggleGroup: Rename Outline and internal class properties to meet conventions Apr 9, 2024
@danielchalmers danielchalmers changed the title ToggleGroup: Rename Outline and internal class properties to meet conventions ToggleGroup: Rename Outline to Outlined and internal refactoring Apr 9, 2024
@danielchalmers
Copy link
Contributor Author

Getting this out of the way before I make actual changes to make reviewing easier

@danielchalmers danielchalmers changed the title ToggleGroup: Rename Outline to Outlined and internal refactoring ToggleGroup: Rename Outline to Outlined, Internal refactoring Apr 9, 2024
@danielchalmers danielchalmers changed the title ToggleGroup: Rename Outline to Outlined, Internal refactoring ToggleGroup: Rename Outline to Outlined & Internal cleanup Apr 10, 2024
@henon henon merged commit ed8b5b8 into MudBlazor:dev Apr 11, 2024
3 of 4 checks passed
@henon
Copy link
Collaborator

henon commented Apr 11, 2024

Thanks @danielchalmers

Added to v7.0.0 Migration Guide #8447

@henon henon mentioned this pull request Apr 11, 2024
@danielchalmers danielchalmers deleted the toggle-rename-properties branch April 12, 2024 18:35
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants